Skip to content

Remove redundant entity_id collision check in entity registry#143660

Merged
emontnemery merged 2 commits intodevfrom
entity_registry_remove_known_object_ids
Apr 28, 2025
Merged

Remove redundant entity_id collision check in entity registry#143660
emontnemery merged 2 commits intodevfrom
entity_registry_remove_known_object_ids

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Remove redundant entity_id collision check in entity registry

This PR essentially reverts the collision check introduced by #19222 which is no longer needed thanks to the more extensive collision check introduced by #42151

The collision check in #19222 only detected collisions within a single entity component.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner April 25, 2025 12:14
@emontnemery emontnemery merged commit cec8db1 into dev Apr 28, 2025
48 checks passed
@emontnemery emontnemery deleted the entity_registry_remove_known_object_ids branch April 28, 2025 05:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants